Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 15031004: Revert "Remove _WorkerStub hack to make benefit closing an isolate." (Closed)

Created:
7 years, 7 months ago by ahe
Modified:
7 years, 7 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Remove _WorkerStub hack to make benefit closing an isolate." This reverts r22669. Committed: https://code.google.com/p/dart/source/detail?r=22672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -99 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 6 chunks +36 lines, -36 lines 0 comments Download
D dart/tests/isolate/isolate_stress_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
TBR: I did not test dart2js checked mode, and there are a few type annotations ...
7 years, 7 months ago (2013-05-14 11:54:38 UTC) #1
ahe
Committed patchset #1 manually as r22672 (presubmit successful).
7 years, 7 months ago (2013-05-14 11:55:13 UTC) #2
ngeoffray
7 years, 7 months ago (2013-05-14 12:02:22 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698