Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 15028010: Report CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_SETTER for top-level setters. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_SETTER for top-level setters. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 3 chunks +17 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 2 chunks +16 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 7 months ago (2013-05-09 16:09:09 UTC) #1
jwren
On 2013/05/09 16:09:09, scheglov wrote: LGTM
7 years, 7 months ago (2013-05-09 16:51:25 UTC) #2
Brian Wilkerson
LGTM
7 years, 7 months ago (2013-05-09 16:54:23 UTC) #3
scheglov
7 years, 7 months ago (2013-05-09 18:10:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698