Avoid syntax errors on oddly named fields.

Avoid syntax errors on oddly named fields.

R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22785

[ahe, 2013-05-15 19:57:33]

This fixes high priority bug http://dartbug.com/10662.

[sra1, 2013-05-16 00:09:31]

lgtm

https://codereview.chromium.org/15024008/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/15024008/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:316:
js('var parameter = "parameter" + i'),
This would give more readable code when you single-step into the generated
constructor:

"parameter_" + field

https://codereview.chromium.org/15024008/diff/1/dart/tests/html/track_element...
File dart/tests/html/track_element_constructor_test.dart (right):

https://codereview.chromium.org/15024008/diff/1/dart/tests/html/track_element...
dart/tests/html/track_element_constructor_test.dart:17: throw 'Expected default
value to be true';
All the other tests under tests/html use the unit test framework.

I would suggest either
(1) change this to the unit test framework
(2) move the test to dart2js_native and construct a test case that has fields
named with all the keywords.

I think for (2) to be useful we would need to make sure the native tests are run
on all the browsers.  I'm not sure we do that.

[ahe, 2013-05-16 12:41:56]

Added a test and committing.

https://codereview.chromium.org/15024008/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
(right):

https://codereview.chromium.org/15024008/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:316:
js('var parameter = "parameter" + i'),
On 2013/05/16 00:09:31, sra1 wrote:
> This would give more readable code when you single-step into the generated
> constructor:
> 
> "parameter_" + field

Great idea. Done.

https://codereview.chromium.org/15024008/diff/1/dart/tests/html/track_element...
File dart/tests/html/track_element_constructor_test.dart (right):

https://codereview.chromium.org/15024008/diff/1/dart/tests/html/track_element...
dart/tests/html/track_element_constructor_test.dart:17: throw 'Expected default
value to be true';
On 2013/05/16 00:09:31, sra1 wrote:
> All the other tests under tests/html use the unit test framework.
> 
> I would suggest either
> (1) change this to the unit test framework
> (2) move the test to dart2js_native and construct a test case that has fields
> named with all the keywords.
> 
> I think for (2) to be useful we would need to make sure the native tests are
run
> on all the browsers.  I'm not sure we do that.

I've added a test to dart2js_native that is much more extensive.

Unfortunately, test failures from pkg:unittest tests are really hard to debug
when you're working on compilers, so I prefer to avoid the framework when
testing the platform.

[ahe, 2013-05-16 12:44:41]

Committed patchset #2 manually as r22785 (presubmit successful).