Issue 15023021: Reapply "Enable full type-checks in checked mode."

Issue 15023021: Reapply "Enable full type-checks in checked mode." (Closed)

Created:
7 years, 7 months ago by karlklose

Modified:
7 years, 7 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Enable full type-checks in checked mode." This reapplies codereview.chromium.org/13019003/ with a bug fix for type-variable references in factory constructors. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=22840

Patch Set 1 #

Patch Set 2 : Fix handling of type-variables in closures inside factories. #

Patch Set 3 : Fix long lines. #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 8

Patch Set 7 : Address comments. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+321 lines, -143 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/closure.dart	View	1 2 3 4 5 6	6 chunks	+51 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1	3 chunks	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		5 chunks	+37 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_rti.dart	View		5 chunks	+27 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 2 3 4 5 6	12 chunks	+93 lines, -43 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View		1 chunk	+69 lines, -63 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		3 chunks	+19 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		2 chunks	+10 lines, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		6 chunks	+2 lines, -10 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/15023021/diff/9002/sdk/lib/_internal/compiler/implementation/closure.dart File sdk/lib/_internal/compiler/implementation/closure.dart (right): https://codereview.chromium.org/15023021/diff/9002/sdk/lib/_internal/compiler/implementation/closure.dart#newcode436 sdk/lib/_internal/compiler/implementation/closure.dart:436: if (member != currentElement && member.isFactoryConstructor() && Instead ...

7 years, 7 months ago (2013-05-17 08:17:45 UTC) #2

karlklose

Thanks, Nicolas. https://codereview.chromium.org/15023021/diff/9002/sdk/lib/_internal/compiler/implementation/closure.dart File sdk/lib/_internal/compiler/implementation/closure.dart (right): https://codereview.chromium.org/15023021/diff/9002/sdk/lib/_internal/compiler/implementation/closure.dart#newcode436 sdk/lib/_internal/compiler/implementation/closure.dart:436: if (member != currentElement && member.isFactoryConstructor() && ...

7 years, 7 months ago (2013-05-17 09:38:34 UTC) #3

karlklose

7 years, 7 months ago (2013-05-17 09:53:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #7 manually as r22840 (presubmit successful).

Expand Messages | Collapse Messages