Issue 15023007: Fix Clank+Dart compilation.

Issue 15023007: Fix Clank+Dart compilation. (Closed)

Created:
7 years, 7 months ago by podivilov

Modified:
7 years, 7 months ago

Reviewers:
vsm, Mads Ager (google), Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Clank+Dart compilation. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22505

Patch Set 3 : . #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -2 lines)			Patch
M	runtime/bin/bin.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/tools/gyp/runtime-configurations.gypi	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
A	runtime/tools/gyp/runtime_configurations_android.gypi	View	1 2	1 chunk	+54 lines, -0 lines	0 comments	Download
M	runtime/vm/vm.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

Adding Ivan as the reviewer since this is changing VM build files.

7 years, 7 months ago (2013-05-07 15:14:55 UTC) #2

Ivan Posva

LGTM with cosmetic comments. -Ivan https://codereview.chromium.org/15023007/diff/2002/runtime/tools/gyp/runtime-configurations.gypi File runtime/tools/gyp/runtime-configurations.gypi (right): https://codereview.chromium.org/15023007/diff/2002/runtime/tools/gyp/runtime-configurations.gypi#newcode24 runtime/tools/gyp/runtime-configurations.gypi:24: [ 'OS=="android"', { 'includes': ...

7 years, 7 months ago (2013-05-08 09:27:35 UTC) #3

podivilov

Committed patchset #3 manually as r22505 (presubmit successful).

7 years, 7 months ago (2013-05-08 13:00:20 UTC) #4

podivilov

7 years, 7 months ago (2013-05-13 09:47:20 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/15023007/diff/2002/runtime/tools/gyp/runtime-...
File runtime/tools/gyp/runtime-configurations.gypi (right):

https://codereview.chromium.org/15023007/diff/2002/runtime/tools/gyp/runtime-...
runtime/tools/gyp/runtime-configurations.gypi:24: [ 'OS=="android"', {
'includes': [ 'runtime_configurations_android.gypi', ], } ],
On 2013/05/08 09:27:35, Ivan Posva wrote:
> Split on multiple lines please. See the conditions below.

Done.

https://codereview.chromium.org/15023007/diff/2002/runtime/tools/gyp/runtime_...
File runtime/tools/gyp/runtime_configurations_android.gypi (right):

https://codereview.chromium.org/15023007/diff/2002/runtime/tools/gyp/runtime_...
runtime/tools/gyp/runtime_configurations_android.gypi:11: 'cflags': [
'-Wno-abi', '-Wall', '-W', '-Wno-unused-parameter',
On 2013/05/08 09:27:35, Ivan Posva wrote:
> One per line.

Done.

Expand Messages | Collapse Messages