Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15004020: Report StaticWarningCode.IMPORT_DUPLICATED_LIBRARY_NAME (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report StaticWarningCode.IMPORT_DUPLICATED_LIBRARY_NAME R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22584

Patch Set 1 #

Total comments: 6

Patch Set 2 : Move check to ErrorVerifier #

Patch Set 3 : Use multiline test sources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -46 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java View 1 chunk +0 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java View 1 chunk +10 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java View 1 1 chunk +5 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 1 5 chunks +53 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 1 2 12 chunks +62 lines, -34 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 1 chunk +11 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java View 1 2 3 chunks +24 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/error.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/utils.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
7 years, 7 months ago (2013-05-10 06:02:42 UTC) #1
Brian Wilkerson
https://codereview.chromium.org/15004020/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/15004020/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode919 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:919: private void checkForImportDuplicateLibraryName(ImportDirective node, LibraryElement library) { Is there ...
7 years, 7 months ago (2013-05-10 14:25:14 UTC) #2
scheglov
PTAL https://codereview.chromium.org/15004020/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/15004020/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode919 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:919: private void checkForImportDuplicateLibraryName(ImportDirective node, LibraryElement library) { On ...
7 years, 7 months ago (2013-05-10 15:03:08 UTC) #3
Brian Wilkerson
LGTM
7 years, 7 months ago (2013-05-10 15:28:56 UTC) #4
scheglov
7 years, 7 months ago (2013-05-10 16:08:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r22584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698