Issue 15001030: Cleanup and avoid unnecessary code when building type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15001030: Cleanup and avoid unnecessary code when building type arguments. (Closed)

Created:
7 years, 7 months ago by Florian Schneider

Modified:
7 years, 7 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanup and avoid unnecessary code when building type arguments. The code now uses only one temporary local instead of two. It affect only unoptimized code since those temporaries are eliminated when translating into SSA. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=22737

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -26 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		2 chunks	+11 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 7 months ago (2013-05-15 13:42:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22737 (presubmit successful).

Expand Messages | Collapse Messages