Issue 14998006: Add some user-friendly utility functions to pkg/analyzer_experimental.

Issue 14998006: Add some user-friendly utility functions to pkg/analyzer_experimental. (Closed)

Created:
7 years, 7 months ago by nweiz

Modified:
7 years, 7 months ago

Reviewers:
Alan Knight, scheglov, Andrei Mouravski, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add some user-friendly utility functions to pkg/analyzer_experimental. R=alanknight@google.com, amouravski@google.com, brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=22567

Patch Set 2 : Code review changes. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+331 lines, -354 lines)			Patch
M	pkg/analyzer_experimental/bin/analyzer.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/analyzer.dart	View		1 chunk	+46 lines, -116 lines	0 comments	Download
D	pkg/analyzer_experimental/lib/error_formatter.dart	View		1 chunk	+0 lines, -143 lines	0 comments	Download
A +	pkg/analyzer_experimental/lib/src/analyzer_impl.dart	View	1	2 chunks	+17 lines, -3 lines	0 comments	Download
A	pkg/analyzer_experimental/lib/src/error.dart	View		1 chunk	+104 lines, -0 lines	0 comments	Download
A +	pkg/analyzer_experimental/lib/src/error_formatter.dart	View	1	1 chunk	+20 lines, -3 lines	0 comments	Download
A	pkg/analyzer_experimental/lib/src/utils.dart	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	pkg/analyzer_experimental/pubspec.yaml	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	pkg/analyzer_experimental/test/error_test.dart	View		1 chunk	+62 lines, -0 lines	0 comments	Download
A	pkg/analyzer_experimental/test/utils.dart	View		1 chunk	+46 lines, -0 lines	0 comments	Download
M	pkg/intl/lib/extract_messages.dart	View		2 chunks	+6 lines, -39 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/src/export_map.dart	View		4 chunks	+3 lines, -46 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM Thank you for making code dartish! https://codereview.chromium.org/14998006/diff/1/pkg/analyzer_experimental/lib/src/analyzer_impl.dart File pkg/analyzer_experimental/lib/src/analyzer_impl.dart (right): https://codereview.chromium.org/14998006/diff/1/pkg/analyzer_experimental/lib/src/analyzer_impl.dart#newcode4 pkg/analyzer_experimental/lib/src/analyzer_impl.dart:4: Missing "library" ...

7 years, 7 months ago (2013-05-09 01:26:46 UTC) #6

nweiz

7 years, 7 months ago (2013-05-09 21:05:52 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r22567 (presubmit successful).

Expand Messages | Collapse Messages