Issue 14997015: trim() does not remove the trailing null characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14997015: trim() does not remove the trailing null characters. (Closed)

Created:
7 years, 7 months ago by zachconrad

Modified:
7 years, 6 months ago

Reviewers:
gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

trim() does not remove the trailing null characters. BUG=https://code.google.com/p/dart/issues/detail?id=10675

Patch Set 1 #

Patch Set 2 : Trying to remove extra files that got included due to not rebasing #

Patch Set 3 : Fixes for webdriver.dart #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	pkg/webdriver/lib/webdriver.dart	View	1 2	3 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zachconrad

On 2013/05/15 20:31:34, gram wrote: > lgtm Is there anything else needed from me to ...

7 years, 7 months ago (2013-05-16 17:29:22 UTC) #2

gram

7 years, 7 months ago (2013-05-16 18:01:21 UTC) #3

On 2013/05/16 17:29:22, zachconrad wrote:
> On 2013/05/15 20:31:34, gram wrote:
> > lgtm
> 
> Is there anything else needed from me to get this patch committed?

No , I will be landing it shortly.

Expand Messages | Collapse Messages