Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 14989011: Fixing overrideMimeType on IE10. (Closed)

Created:
7 years, 7 months ago by blois
Modified:
7 years, 7 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing overrideMimeType on IE10. I thought the test was failing for a different reason earlier, but it's that overrideMimeType is not supported on IE. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=22607

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M tests/html/html.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/html/xhr_test.dart View 3 chunks +15 lines, -1 line 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 7 months ago (2013-05-10 23:43:33 UTC) #1
Emily Fortuna
lgtm
7 years, 7 months ago (2013-05-10 23:45:16 UTC) #2
blois
7 years, 7 months ago (2013-05-10 23:47:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698