Issue 14988003: Support redirect to relative Uri, as specified by rfc3986#4.2.

Issue 14988003: Support redirect to relative Uri, as specified by rfc3986#4.2. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support redirect to relative Uri, as specified by rfc3986#4.2. BUG=https://code.google.com/p/dart/issues/detail?id=10210 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22413

Patch Set 1 #

Total comments: 4

Patch Set 2 : Test for only-domain-missing, paths with '..', and simplify tests. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -0 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
	M	tests/standalone/io/http_redirect_test.dart	View	1	3 chunks	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/14988003/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/14988003/diff/1/sdk/lib/io/http_impl.dart#newcode1414 sdk/lib/io/http_impl.dart:1414: _HttpClientRequest previous) { Remove the first URI in ...

7 years, 7 months ago (2013-05-06 13:26:11 UTC) #2

Anders Johnsen

Landing. https://codereview.chromium.org/14988003/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/14988003/diff/1/sdk/lib/io/http_impl.dart#newcode1414 sdk/lib/io/http_impl.dart:1414: _HttpClientRequest previous) { On 2013/05/06 13:26:11, Søren Gjesse ...

7 years, 7 months ago (2013-05-06 13:59:04 UTC) #3

Anders Johnsen

7 years, 7 months ago (2013-05-06 13:59:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22413 (presubmit successful).

Expand Messages | Collapse Messages