Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1498613002: Further improve isWithin() performance. (Closed)

Created:
5 years ago by nweiz
Modified:
5 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org, scheglov
Base URL:
git@github.com:dart-lang/path@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Further improve isWithin() performance. On @scheglov's benchmark data, which include many path containing `.pub` or `.pub-cache`, this results in a further ~8x improvement over the improvements in e6b55472da7bfcfcc20db163abadfbd7689dd23c. On the repo benchmark, this results in a further ~1.2x improvement. Closes #7 R=rnystrom@google.com Committed: https://github.com/dart-lang/path/commit/9c38bf477913a6d64bdf6047a9800788ffeec3b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -13 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/context.dart View 1 chunk +57 lines, -12 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
nweiz
5 years ago (2015-12-02 21:35:28 UTC) #3
Bob Nystrom
lgtm
5 years ago (2015-12-02 22:07:28 UTC) #4
nweiz
5 years ago (2015-12-02 22:08:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c38bf477913a6d64bdf6047a9800788ffeec3b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698