Issue 149853004: Find all compiled copies of a function when setting breakpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149853004: Find all compiled copies of a function when setting breakpoint (Closed)

Created:
6 years, 10 months ago by hausner

Modified:
6 years, 10 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Jacob, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Find all compiled copies of a function when setting breakpoint Fixes a bug where the debugger did not find a compiled implicit closure if the non-closureized version had not been compiled yet, thus failing to set a breakpoint. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=32165

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -52 lines)			Patch
M	runtime/vm/debugger.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1	7 chunks	+42 lines, -48 lines	0 comments	Download
A	tests/standalone/debugger/closure_bp_test.dart	View	1 2	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

6 years, 10 months ago (2014-01-30 18:08:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32165 (presubmit successful).

Expand Messages | Collapse Messages