Issue 14985013: Report CompileTimeErrorCode.CONST_WITH_UNDEFINED_CONSTRUCTOR

Issue 14985013: Report CompileTimeErrorCode.CONST_WITH_UNDEFINED_CONSTRUCTOR (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report CompileTimeErrorCode.CONST_WITH_UNDEFINED_CONSTRUCTOR R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22631

Patch Set 2 : tweak #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -19 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	2 chunks	+37 lines, -0 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		2 chunks	+26 lines, -13 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/14985013/diff/3001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/14985013/diff/3001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode430 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:430: checkForConstWithUndefinedConstructor(node); There are two methods so far that ...

7 years, 7 months ago (2013-05-13 13:58:02 UTC) #2

scheglov

Committed patchset #2 manually as r22631 (presubmit successful).

7 years, 7 months ago (2013-05-13 16:23:07 UTC) #3

scheglov

7 years, 7 months ago (2013-05-13 16:23:42 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14985013/diff/3001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/14985013/diff/3001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:430:
checkForConstWithUndefinedConstructor(node);
On 2013/05/13 13:58:02, Brian Wilkerson wrote:
> There are two methods so far that both check for 'const'. It would be more
> efficient to check for 'const' one time here rather than once per method.

Done.

Expand Messages | Collapse Messages