Issue 14980002: Fix for issue 10395, call noSUchMethod if a method is not found when using the Dart C API.

Issue 14980002: Fix for issue 10395, call noSUchMethod if a method is not found when using the Dart C API. (Closed)

Created:
7 years, 7 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for issue 10395, call noSuchMethod if a method is not found when using the Dart C API. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22432

Patch Set 3 : #

Total comments: 4

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -33 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View	1 2	6 chunks	+31 lines, -23 lines	2 comments	Download
	M	runtime/vm/dart_api_impl_test.cc	View	1 2	2 chunks	+73 lines, -10 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://chromiumcodereview.appspot.com/14980002/diff/7001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://chromiumcodereview.appspot.com/14980002/diff/7001/runtime/vm/dart_api_impl_test.cc#newcode3759 runtime/vm/dart_api_impl_test.cc:3759: " with matching arguments"); Please add a test ...

7 years, 7 months ago (2013-05-06 16:10:41 UTC) #2

siva

https://chromiumcodereview.appspot.com/14980002/diff/7001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://chromiumcodereview.appspot.com/14980002/diff/7001/runtime/vm/dart_api_impl_test.cc#newcode3759 runtime/vm/dart_api_impl_test.cc:3759: " with matching arguments"); I did add one, see ...

7 years, 7 months ago (2013-05-06 16:20:25 UTC) #3

siva

Committed patchset #3 manually as r22432 (presubmit successful).

7 years, 7 months ago (2013-05-06 17:07:37 UTC) #4

Ivan Posva

https://codereview.chromium.org/14980002/diff/7001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (left): https://codereview.chromium.org/14980002/diff/7001/runtime/vm/dart_api_impl.cc#oldcode3808 runtime/vm/dart_api_impl.cc:3808: Instance& instance = Instance::Handle(isolate); Any particular reason for dropping ...

7 years, 7 months ago (2013-05-07 09:58:43 UTC) #5

siva

7 years, 7 months ago (2013-05-07 15:40:52 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/14980002/diff/7001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (left):

https://codereview.chromium.org/14980002/diff/7001/runtime/vm/dart_api_impl.c...
runtime/vm/dart_api_impl.cc:3808: Instance& instance =
Instance::Handle(isolate);
No particular reason.

I initially tries to change this to Instance::Cast(obj)

but this was causing issues when obj was Null and so turned it back to Handle
but forgot the isolate parameter.
(Need to check why Cast fails on Null).

On 2013/05/07 09:58:43, Ivan Posva wrote:
> Any particular reason for dropping the isolate parameter?

Expand Messages | Collapse Messages