Issue 14979007: - Canonicalize array bounds checks to avoid deopting when comparing

Issue 14979007: - Canonicalize array bounds checks to avoid deopting when comparing (Closed)

Created:
7 years, 7 months ago by Ivan Posva

Modified:
7 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Canonicalize array bounds checks to avoid deopting when comparing two constants. - Add named locations for index and length to make using locs less confusing. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22698

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -76 lines)			Patch
M	runtime/vm/intermediate_language.h	View	1	3 chunks	+11 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	1 chunk	+21 lines, -17 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+21 lines, -19 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	1 chunk	+21 lines, -17 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+21 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM! https://codereview.chromium.org/14979007/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/14979007/diff/1/runtime/vm/intermediate_language.h#newcode6191 runtime/vm/intermediate_language.h:6191: locIndex = 1 Optional: prefix constant with k, ...

7 years, 7 months ago (2013-05-14 18:11:47 UTC) #2

Ivan Posva

https://codereview.chromium.org/14979007/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/14979007/diff/1/runtime/vm/intermediate_language.h#newcode6191 runtime/vm/intermediate_language.h:6191: locIndex = 1 On 2013/05/14 18:11:47, srdjan wrote: > ...

7 years, 7 months ago (2013-05-14 18:30:30 UTC) #3

Ivan Posva

7 years, 7 months ago (2013-05-14 18:39:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22698 (presubmit successful).

Expand Messages | Collapse Messages