Remove more question marks.

Remove more question marks.

R=antonm@google.com, blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23563

[Andrei Mouravski, 2013-05-07 23:24:22]

This is not quite there yet, so please do not LGTM, I just wanted to get it in
your hands to take a look.

[blois, 2013-05-07 23:44:41]

+sra, who has shot holes in many previous changes in this area :)

[sra1, 2013-05-08 20:54:08]

I don't see any 'obvious' problems.
What you might do is look at the tests to see if there is any coverage of the
optional arguments, especially those declared as nullable in the IDL.

[Andrei Mouravski, 2013-05-09 21:14:29]

I removed all the ? from everywhere and added a test to make sure optional stuff
still works.

[sra1, 2013-05-09 22:11:20]

Pete - any comments?

https://codereview.chromium.org/14976004/diff/12001/tests/html/canvasrenderin...
File tests/html/canvasrenderingcontext2d_test.dart (right):

https://codereview.chromium.org/14976004/diff/12001/tests/html/canvasrenderin...
tests/html/canvasrenderingcontext2d_test.dart:198:
context.putImageData(drawnData, 0, 0, 1, 1, 5, 5);
Have a separate test for passing 4/5/6 arguments to show it throws.

https://codereview.chromium.org/14976004/diff/12001/tests/html/canvasrenderin...
tests/html/canvasrenderingcontext2d_test.dart:200: // Expect the data to be all
green, as we skip all drawn pixels.
Have one pixel actually change otherwise the test will pass if you comment out
the putImageData call.

[blois, 2013-05-09 22:35:21]

Minor nit, and canvas test should be updated per sra.

https://codereview.chromium.org/14976004/diff/12001/tools/dom/scripts/htmldar...
File tools/dom/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/14976004/diff/12001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:244: checks.extend(['%s == null' % name
for name in parameter_names[argument_count:]])
line length

[blois, 2013-05-11 00:05:58]

lgtm

[Anton Muhin, 2013-05-14 14:48:23]

https://codereview.chromium.org/14976004/diff/12001/tools/dom/scripts/htmldar...
File tools/dom/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/14976004/diff/12001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:244: checks.extend(['%s == null' % name
for name in parameter_names[argument_count:]])
BTW, another potential source of semantic differences.

Regard something like foo(A a) and foo() overloads.  Formerly we could
distinguish one from another, now we will always default to the first one.

https://codereview.chromium.org/14976004/diff/12001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:385: inits = self._members_emitter.Emit(
please, a separate change or rebase if not too late

[Anton Muhin, 2013-05-24 09:34:49]

what's the status of this CL?

[Andrei Mouravski, 2013-05-28 23:04:18]

Okay, this is all rebased after the recent changes.

PTAL.

[Anton Muhin, 2013-05-29 09:50:25]

https://codereview.chromium.org/14976004/diff/26001/tools/dom/scripts/htmldar...
File tools/dom/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/14976004/diff/26001/tools/dom/scripts/htmldar...
tools/dom/scripts/htmldartgenerator.py:257: checks.extend(['%s == null' % name
for name in parameter_names[argument_count:]])
what about nullable arguments?  and arguments which allow nulls, marked
TreatNullAs=NullString at least?

[Anton Muhin, 2013-05-30 13:34:05]

Sorry, failed to find cycles today.  Please, go ahead and submit, I'll have a
look later.

LGTM

[Andrei Mouravski, 2013-06-03 19:57:07]

Committed patchset #9 manually as r23563 (presubmit successful).