Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Issue 149723004: Fix docgen.bat so it can start docgen from snapshot. (Closed)

Created:
6 years, 10 months ago by aam-me
Modified:
6 years, 10 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix docgen.bat so it can start docgen from snapshot. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=32145

Patch Set 1 #

Patch Set 2 : Dropped --package-root from snapshot invocation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/bin/docgen.bat View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
aam-me
Hi Alan, just noticed docgen is giving trouble on Windows. This patch fixes the problem. ...
6 years, 10 months ago (2014-01-29 20:41:18 UTC) #1
Alan Knight
Thanks. lgtm.
6 years, 10 months ago (2014-01-29 21:48:10 UTC) #2
aam-me
6 years, 10 months ago (2014-01-29 22:09:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32145 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698