Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 149723002: Share the same type parameters of a mixin application class to propagate (Closed)

Created:
6 years, 10 months ago by regis
Modified:
6 years, 10 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Share the same type parameters of a mixin application class to propagate identical type arguments to the super type and to the mixin type, thereby allowing for further optimizations, such as instantiator vector reuse or sharing of type arguments with the super class. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=32140

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M runtime/vm/class_finalizer.cc View 1 4 chunks +58 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
6 years, 10 months ago (2014-01-29 19:46:52 UTC) #1
srdjan
LGTM with comment https://codereview.chromium.org/149723002/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/149723002/diff/1/runtime/vm/class_finalizer.cc#newcode1432 runtime/vm/class_finalizer.cc:1432: for (intptr_t i = name.Length(); --i ...
6 years, 10 months ago (2014-01-29 20:33:26 UTC) #2
regis
Thanks! https://codereview.chromium.org/149723002/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/149723002/diff/1/runtime/vm/class_finalizer.cc#newcode1432 runtime/vm/class_finalizer.cc:1432: for (intptr_t i = name.Length(); --i > 0; ...
6 years, 10 months ago (2014-01-29 21:10:34 UTC) #3
regis
6 years, 10 months ago (2014-01-29 21:10:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r32140 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698