Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 14969024: Fix parser in case of unmatched angle bracket. (Closed)

Created:
7 years, 7 months ago by qsr
Modified:
7 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix parser in case of unmatched angle bracket. BUG= http://dartbug.com/10008 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=22741

Patch Set 1 #

Patch Set 2 : Re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/parser_test.dart View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ahe
LGTM! Are you a Dart committer, or do you need my help to commit?
7 years, 7 months ago (2013-05-15 13:12:05 UTC) #1
qsr
I'm not a Dart committer, you will have to push that for me.
7 years, 7 months ago (2013-05-15 13:13:10 UTC) #2
ahe
7 years, 7 months ago (2013-05-15 14:43:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22741 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698