Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 14969019: A load static of an initialized static final field can be converted to its value, as long as it is … (Closed)

Created:
7 years, 7 months ago by srdjan
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

A load static of an initialized static final field can be converted to its value, as long as it is in old space or Smi, and can therefore be a literal node. Add special objects to mark non_constant and unknown_constant in constant propagator so that there is no confusion with sentinels used in the graph. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22600

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M runtime/vm/flow_graph_optimizer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 2 chunks +11 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 5 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
srdjan
7 years, 7 months ago (2013-05-10 18:33:23 UTC) #1
siva
lgtm https://codereview.chromium.org/14969019/diff/3001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/14969019/diff/3001/runtime/vm/object.h#newcode345 runtime/vm/object.h:345: } Can you move this new block to ...
7 years, 7 months ago (2013-05-10 20:13:35 UTC) #2
srdjan
https://codereview.chromium.org/14969019/diff/3001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/14969019/diff/3001/runtime/vm/object.h#newcode345 runtime/vm/object.h:345: } On 2013/05/10 20:13:35, siva wrote: > Can you ...
7 years, 7 months ago (2013-05-10 21:03:04 UTC) #3
srdjan
Committed patchset #3 manually as r22600 (presubmit successful).
7 years, 7 months ago (2013-05-10 21:33:18 UTC) #4
Kevin Millikin (Google)
7 years, 7 months ago (2013-05-13 08:13:10 UTC) #5
Message was sent while issue was closed.
LGTM, and thanks for making the constant propagator safer.

Powered by Google App Engine
This is Rietveld 408576698