Issue 1496683003: Add RunnerSuite.{on,is}Debugging properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1496683003: Add RunnerSuite.{on,is}Debugging properties. (Closed)

Created:
5 years ago by nweiz

Modified:
5 years ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add RunnerSuite.{on,is}Debugging properties. This reverts commit 8833887b99b28d328663dc595c3a7a300513b104 and re-applies commit 71bfbdcd1b89ab62df9bf3a1a6f48bffe8c63974. The original commit sometimes marked a controller as debugging or not debugging after it had been closed. This fixes that bug. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/5479a663ad73ce033aa7adde618bd7eca3aae242

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+268 lines, -106 lines)			Patch
M	lib/src/runner/browser/browser_manager.dart	View	3 chunks	+10 lines, -86 lines	0 comments	Download
M	lib/src/runner/browser/iframe_listener.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	lib/src/runner/browser/suite.dart	View	1 chunk	+167 lines, -0 lines	0 comments	Download
M	lib/src/runner/load_suite.dart	View	7 chunks	+14 lines, -5 lines	0 comments	Download
M	lib/src/runner/runner_suite.dart	View	1 chunk	+72 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nweiz

5 years ago (2015-12-04 01:05:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5479a663ad73ce033aa7adde618bd7eca3aae242 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages