Issue 14961005: Speculative fix for android build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14961005: Speculative fix for android build. (Closed)

Created:
7 years, 7 months ago by ricow1

Modified:
7 years, 7 months ago

Reviewers:
vsm, gram, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Speculative fix for android build. It is really hard to follow the directory logic, with DART_DIR being just ../../.. and a few pushd and cd commands thrown in. I don't particularly like this solution either, this is basically to verify that I am assuming correctly in that this is caused by the relative paths being messed up. Committed: https://code.google.com/p/dart/source/detail?r=22494

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/embedders/openglui/build_skia.sh	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r22494 (presubmit successful).

7 years, 7 months ago (2013-05-08 06:22:28 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages