Default to UTF-8 in the HTTP package.

Default to UTF-8 in the HTTP package.

This makes ByteStream.toStringStream respect its Encoding properly.
[decodeString] and [encodeString] are still unable to do so (see issue 6284).

BUG=10573
R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22805

[Bob Nystrom, 2013-05-16 16:11:39]

One suggestion, otherwise LGTM.

https://codereview.chromium.org/14958005/diff/1/pkg/http/lib/src/utils.dart
File pkg/http/lib/src/utils.dart (right):

https://codereview.chromium.org/14958005/diff/1/pkg/http/lib/src/utils.dart#n...
pkg/http/lib/src/utils.dart:97: // TODO(nweiz): implement this once issue 6284
is fixed.
How about throwing NotImplementedError if [encoding] is not UTF-8?

https://codereview.chromium.org/14958005/diff/1/pkg/http/lib/src/utils.dart#n...
pkg/http/lib/src/utils.dart:103: // TODO(nweiz): implement this once issue 6284
is fixed.
Ditto.

[nweiz, 2013-05-16 18:32:46]

https://codereview.chromium.org/14958005/diff/1/pkg/http/lib/src/utils.dart
File pkg/http/lib/src/utils.dart (right):

https://codereview.chromium.org/14958005/diff/1/pkg/http/lib/src/utils.dart#n...
pkg/http/lib/src/utils.dart:97: // TODO(nweiz): implement this once issue 6284
is fixed.
On 2013/05/16 16:11:39, Bob Nystrom wrote:
> How about throwing NotImplementedError if [encoding] is not UTF-8?

I suspect most of the time when encodings get set to something other than the
default, they're coming from some external configuration rather than from the
user of http explicitly deciding they want ISO-8859-1 in particular. For
example, this gets called with an encoding that's derived from the response
headers. In cases like that, I think it's better to garble the non-ASCII text
(which may not even exist) than to just crash.

[nweiz, 2013-05-16 18:33:14]

Committed patchset #1 manually as r22805 (presubmit successful).