Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 149533003: Reapply "Make reflectClassByName work with interceptor names." (Closed)

Created:
6 years, 10 months ago by karlklose
Modified:
6 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Make reflectClassByName work with interceptor names." R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32158

Patch Set 1 #

Patch Set 2 : Comment out test failing due to issue 16389. #

Patch Set 3 : Update test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M sdk/lib/_internal/lib/js_mirrors.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A tests/compiler/dart2js_extra/reflect_native_types_test.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
6 years, 10 months ago (2014-01-29 13:40:55 UTC) #1
floitsch
LGTM.
6 years, 10 months ago (2014-01-29 15:11:46 UTC) #2
karlklose
6 years, 10 months ago (2014-01-30 12:48:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r32158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698