Retry "Changes for webkit roll 148757-149482"

Retry "Changes for webkit roll 148757-149482"

TBR=antonm

Committed: https://code.google.com/p/dart/source/detail?r=22801

[vsm, 2013-05-16 16:39:16]

Committed patchset #1 manually as r22801 (presubmit successful).

[Anton Muhin, 2013-05-17 09:55:05]

https://codereview.chromium.org/14948011/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/14948011/diff/1/tests/html/html.status#newcode7
tests/html/html.status:7: svg_test: Skip #TODO(vsm): investigating
maybe a bug, or you're really close?

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/idlnode.py
File tools/dom/scripts/idlnode.py (right):

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/idlnode.py#...
tools/dom/scripts/idlnode.py:414: self.ext_attrs['Callback'] = None
I think it should be properties on the IDLInterface objects.  May we add TODOs
at least (here and for the case right below)

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/idlnode.py#...
tools/dom/scripts/idlnode.py:512: self.ext_attrs['Callback'] = None
ditto

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:18: ('DOMWindow', 'indexedDB'):
'DOMWindowIndexedDatabase',
is this temporary?  if yes, please, add a TODO

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:41: for (type, member) in
_cpp_type_map.keys():
nit: please, no () around type, member

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:44:
_cpp_partial_map[type].add(_cpp_type_map[(type, member)])
_cpp_partial_map.setdefault(type, set()).add(....)

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:46: if interface_name in _cpp_partial_map:
return _cpp_partial_map.get(interface_name, set())

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:55: cpp_tuple = (interface_name,
callback_name)
return _cpp_type_name.get((interface_name, callback_name), interface_name)

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:408: elif attr.id == 'CSS':
this is a rename, correct?  There is this implementedBy attribute which should
help here

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:852: cpp_type_name =
_GetCPPTypeName(interface_name,
nit: single line

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:856: cpp_arguments.insert(0, 'receiver')
just curious: does the position (1st/last) indeed depends on interface name?

https://codereview.chromium.org/14948011/diff/1/tools/dom/scripts/systemnativ...
tools/dom/scripts/systemnative.py:942: cpp_type_name =
_GetCPPTypeName(interface_name, function_name)
overall it looks like _GetCPPTypeName should return None if there is no override
as in most (all?) the cases you do a dispatch anyway.