Issue 14935012: Update status file for flaky test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14935012: Update status file for flaky test. (Closed)

Created:
7 years, 7 months ago by ngeoffray

Modified:
7 years, 7 months ago

Reviewers:
ricow1, ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update status file for flaky test. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=22622

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	tests/isolate/isolate.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tools/testing/dart/test_options.dart	View		1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM, is the nocsp just in anticipation of future needs? https://codereview.chromium.org/14935012/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://codereview.chromium.org/14935012/diff/1/tools/testing/dart/test_options.dart#newcode516 ...

7 years, 7 months ago (2013-05-13 12:50:22 UTC) #2

ngeoffray

Thanks Rico https://codereview.chromium.org/14935012/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): https://codereview.chromium.org/14935012/diff/1/tools/testing/dart/test_options.dart#newcode516 tools/testing/dart/test_options.dart:516: configuration['nocsp'] = !configuration['csp']; On 2013/05/13 12:50:22, ricow1 ...

7 years, 7 months ago (2013-05-13 13:00:09 UTC) #3

ngeoffray

7 years, 7 months ago (2013-05-13 13:01:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22622 (presubmit successful).

Expand Messages | Collapse Messages