move workaround from CE polyfill to custom elements createdCallback

move workaround from CE polyfill to custom elements createdCallback

github changes: https://github.com/dart-lang/CustomElements/pull/5

R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32307

[Jennifer Messerly, 2014-02-03 21:49:21]

the first baby step to unforking CE ...

[blois, 2014-02-04 00:02:06]

https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
File tools/dom/src/dart2js_CustomElementSupport.dart (right):

https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
tools/dom/src/dart2js_CustomElementSupport.dart:14: JS('', '#.constructor =
#.__proto__.constructor', receiver, receiver);
Should this be in setNativeSubclassDispatchRecord? Seems like it's part of the
work that it's already doing.

[Jennifer Messerly, 2014-02-04 00:28:18]

https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
File tools/dom/src/dart2js_CustomElementSupport.dart (right):

https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
tools/dom/src/dart2js_CustomElementSupport.dart:14: JS('', '#.constructor =
#.__proto__.constructor', receiver, receiver);
On 2014/02/04 00:02:06, blois wrote:
> Should this be in setNativeSubclassDispatchRecord? Seems like it's part of the
> work that it's already doing.

Hmmm, that's a good question. I don't think so. setNativeSubclassDispatchRecord
is part of dart2js in sdk/lib/_internal, whereas this code is specific to
dart2js custom elements support (and the polyfill only, for that matter). So 
dart2js_CustomElementSupport.dart seems like the right place for this code to
live. IMHO.

[Jennifer Messerly, 2014-02-04 00:31:49]

On 2014/02/04 00:28:18, John Messerly wrote:
>
https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
> File tools/dom/src/dart2js_CustomElementSupport.dart (right):
> 
>
https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
> tools/dom/src/dart2js_CustomElementSupport.dart:14: JS('', '#.constructor =
> #.__proto__.constructor', receiver, receiver);
> On 2014/02/04 00:02:06, blois wrote:
> > Should this be in setNativeSubclassDispatchRecord? Seems like it's part of
the
> > work that it's already doing.
> 
> Hmmm, that's a good question. I don't think so.
setNativeSubclassDispatchRecord
> is part of dart2js in sdk/lib/_internal, whereas this code is specific to
> dart2js custom elements support (and the polyfill only, for that matter). So 
> dart2js_CustomElementSupport.dart seems like the right place for this code to
> live. IMHO.

BTW -- it is a good question whether dart2js mirrors is actually using the right
object to cache its mirrors state. I'm not sure. Maybe it should use the native
dispatch record instead of the constructor (do pure Dart objects have "native
dispatch records"?). But that's not what dart2js mirrors is currently doing,
hence this code.

[blois, 2014-02-04 00:33:08]

On 2014/02/04 00:31:49, John Messerly wrote:
> On 2014/02/04 00:28:18, John Messerly wrote:
> >
>
https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
> > File tools/dom/src/dart2js_CustomElementSupport.dart (right):
> > 
> >
>
https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
> > tools/dom/src/dart2js_CustomElementSupport.dart:14: JS('', '#.constructor =
> > #.__proto__.constructor', receiver, receiver);
> > On 2014/02/04 00:02:06, blois wrote:
> > > Should this be in setNativeSubclassDispatchRecord? Seems like it's part of
> the
> > > work that it's already doing.
> > 
> > Hmmm, that's a good question. I don't think so.
> setNativeSubclassDispatchRecord
> > is part of dart2js in sdk/lib/_internal, whereas this code is specific to
> > dart2js custom elements support (and the polyfill only, for that matter). So

> > dart2js_CustomElementSupport.dart seems like the right place for this code
to
> > live. IMHO.
> 
> BTW -- it is a good question whether dart2js mirrors is actually using the
right
> object to cache its mirrors state. I'm not sure. Maybe it should use the
native
> dispatch record instead of the constructor (do pure Dart objects have "native
> dispatch records"?). But that's not what dart2js mirrors is currently doing,
> hence this code.

I believe that custom elements are the only thing using that code right now,
will defer to Stephen though.

[Jennifer Messerly, 2014-02-04 00:35:38]

On 2014/02/04 00:33:08, blois wrote:
> On 2014/02/04 00:31:49, John Messerly wrote:
> > On 2014/02/04 00:28:18, John Messerly wrote:
> > >
> >
>
https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
> > > File tools/dom/src/dart2js_CustomElementSupport.dart (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
> > > tools/dom/src/dart2js_CustomElementSupport.dart:14: JS('', '#.constructor
=
> > > #.__proto__.constructor', receiver, receiver);
> > > On 2014/02/04 00:02:06, blois wrote:
> > > > Should this be in setNativeSubclassDispatchRecord? Seems like it's part
of
> > the
> > > > work that it's already doing.
> > > 
> > > Hmmm, that's a good question. I don't think so.
> > setNativeSubclassDispatchRecord
> > > is part of dart2js in sdk/lib/_internal, whereas this code is specific to
> > > dart2js custom elements support (and the polyfill only, for that matter).
So
> 
> > > dart2js_CustomElementSupport.dart seems like the right place for this code
> to
> > > live. IMHO.
> > 
> > BTW -- it is a good question whether dart2js mirrors is actually using the
> right
> > object to cache its mirrors state. I'm not sure. Maybe it should use the
> native
> > dispatch record instead of the constructor (do pure Dart objects have
"native
> > dispatch records"?). But that's not what dart2js mirrors is currently doing,
> > hence this code.
> 
> I believe that custom elements are the only thing using that code right now,
> will defer to Stephen though.

It is true for this one function:

setNativeSubclassDispatchRecord(proto, interceptor) {
  setDispatchProperty(proto, makeLeafDispatchRecord(interceptor));
}

... but honestly, this function could just as easily be moved into
dart2js_CustomElementSupport.dart

The two functions it calls are both used elsewhere.

I would strongly like to avoid touching sdk/lib/_internal for a purely custom
elements change.

[Jennifer Messerly, 2014-02-04 21:14:20]

Friendly ping :)  This is blocking our task to unfork polyfills from polymer-js.

[sra1, 2014-02-05 00:40:42]

lgtm

https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
File tools/dom/src/dart2js_CustomElementSupport.dart (right):

https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
tools/dom/src/dart2js_CustomElementSupport.dart:14: JS('', '#.constructor =
#.__proto__.constructor', receiver, receiver);
On 2014/02/04 00:28:18, John Messerly wrote:
> On 2014/02/04 00:02:06, blois wrote:
> > Should this be in setNativeSubclassDispatchRecord? Seems like it's part of
the
> > work that it's already doing.
> 
> Hmmm, that's a good question. I don't think so.
setNativeSubclassDispatchRecord
> is part of dart2js in sdk/lib/_internal, whereas this code is specific to
> dart2js custom elements support (and the polyfill only, for that matter). So 
> dart2js_CustomElementSupport.dart seems like the right place for this code to
> live. IMHO.

Lets keep 'setNativeSubclassDispatchRecord' setting just the dispatch record for
now.

[Jennifer Messerly, 2014-02-05 01:59:11]

On 2014/02/05 00:40:42, sra1 wrote:
> lgtm
> 
>
https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
> File tools/dom/src/dart2js_CustomElementSupport.dart (right):
> 
>
https://codereview.chromium.org/149313004/diff/1/tools/dom/src/dart2js_Custom...
> tools/dom/src/dart2js_CustomElementSupport.dart:14: JS('', '#.constructor =
> #.__proto__.constructor', receiver, receiver);
> On 2014/02/04 00:28:18, John Messerly wrote:
> > On 2014/02/04 00:02:06, blois wrote:
> > > Should this be in setNativeSubclassDispatchRecord? Seems like it's part of
> the
> > > work that it's already doing.
> > 
> > Hmmm, that's a good question. I don't think so.
> setNativeSubclassDispatchRecord
> > is part of dart2js in sdk/lib/_internal, whereas this code is specific to
> > dart2js custom elements support (and the polyfill only, for that matter). So

> > dart2js_CustomElementSupport.dart seems like the right place for this code
to
> > live. IMHO.
> 
> Lets keep 'setNativeSubclassDispatchRecord' setting just the dispatch record
for
> now.

sounds good. Thanks!

[Jennifer Messerly, 2014-02-05 04:15:40]

Committed patchset #2 manually as r32307 (presubmit successful).