Issue 14927003: Revert 22380 to investigate windows build break.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14927003: Revert 22380 to investigate windows build break. (Closed)

Created:
7 years, 7 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert 22380 to investigate windows build break. Committed: https://code.google.com/p/dart/source/detail?r=22382

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+429 lines, -558 lines)			Patch
M	runtime/bin/dartutils.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	4 chunks	+20 lines, -57 lines	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/bin/main.cc	View	2 chunks	+21 lines, -4 lines	0 comments	Download
M	runtime/bin/run_vm_tests.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/include/dart_api.h	View	2 chunks	+1 line, -33 lines	0 comments	Download
D	runtime/lib/corelib_sources.gypi	View	1 chunk	+0 lines, -57 lines	0 comments	Download
A +	runtime/lib/lib_sources.gypi	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	runtime/lib/libgen_in.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	runtime/tools/gen_library_src_paths.py	View	1 chunk	+0 lines, -105 lines	0 comments	Download
M	runtime/vm/bootstrap.h	View	1 chunk	+12 lines, -15 lines	0 comments	Download
M	runtime/vm/bootstrap.cc	View	6 chunks	+51 lines, -138 lines	0 comments	Download
M	runtime/vm/dart.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/dart.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate.h	View	3 chunks	+0 lines, -6 lines	0 comments	Download
	runtime/vm/isolate.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/os_android.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/vm.gypi	View	24 chunks	+315 lines, -101 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

Committed patchset #1 manually as r22382 (presubmit successful).

7 years, 7 months ago (2013-05-03 18:26:44 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages