Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14925005: Remove stack_frame_<arch>.cc files. (Closed)

Created:
7 years, 7 months ago by regis
Modified:
7 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove stack_frame_<arch>.cc files. The architecture specific information is in stack_frame_<arch>.h files. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22470

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -519 lines) Patch
M runtime/vm/assembler_arm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_ia32.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_mips.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_x64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 1 3 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 7 chunks +15 lines, -15 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 7 chunks +16 lines, -15 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 7 chunks +16 lines, -15 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 7 chunks +16 lines, -15 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/locations.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/vm/scopes.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/stack_frame.h View 1 4 chunks +11 lines, -16 lines 0 comments Download
M runtime/vm/stack_frame.cc View 1 6 chunks +39 lines, -23 lines 0 comments Download
M runtime/vm/stack_frame_arm.h View 1 1 chunk +24 lines, -17 lines 0 comments Download
D runtime/vm/stack_frame_arm.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download
M runtime/vm/stack_frame_ia32.h View 1 1 chunk +22 lines, -15 lines 0 comments Download
D runtime/vm/stack_frame_ia32.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download
M runtime/vm/stack_frame_mips.h View 1 1 chunk +24 lines, -17 lines 0 comments Download
D runtime/vm/stack_frame_mips.cc View 1 1 chunk +0 lines, -67 lines 0 comments Download
M runtime/vm/stack_frame_x64.h View 1 1 chunk +22 lines, -15 lines 0 comments Download
D runtime/vm/stack_frame_x64.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 5 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 3 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 5 chunks +9 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 3 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
This is mostly a mechanical change.
7 years, 7 months ago (2013-05-07 05:12:12 UTC) #1
srdjan
lgtm
7 years, 7 months ago (2013-05-07 18:05:31 UTC) #2
regis
7 years, 7 months ago (2013-05-07 18:06:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r22470 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698