Issue 1492323004: Fix a crash in Chain.terse and Chain.foldFrames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1492323004: Fix a crash in Chain.terse and Chain.foldFrames. (Closed)

Created:
5 years ago by nweiz

Modified:
4 years, 11 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/stack_trace@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix a crash in Chain.terse and Chain.foldFrames. These methods didn't gracefully handle a chain with an empty frame, which comes up occasionally in practice. Closes #9 R=rnystrom@google.com Committed: https://github.com/dart-lang/stack_trace/commit/2f213c866cbde640b758c73eb0c3887152173cf4

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -2 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/chain.dart	View	2 chunks	+1 line, -1 line	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/chain/chain_test.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

nweiz

4 years, 11 months ago (2016-01-11 22:24:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2f213c866cbde640b758c73eb0c3887152173cf4 (presubmit successful).