Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1491923005: Add a LazyStream class. (Closed)

Created:
5 years ago by nweiz
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 13

Patch Set 2 : Code review changes #

Total comments: 2

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -3 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/async.dart View 1 chunk +1 line, -0 lines 0 comments Download
A lib/src/lazy_stream.dart View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M lib/src/stream_splitter.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/subscription_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/lazy_stream_test.dart View 1 2 1 chunk +106 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
nweiz
5 years ago (2015-12-02 22:50:06 UTC) #1
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1491923005/diff/1/lib/src/lazy_stream.dart File lib/src/lazy_stream.dart (right): https://codereview.chromium.org/1491923005/diff/1/lib/src/lazy_stream.dart#newcode24 lib/src/lazy_stream.dart:24: /// The [callback] may return a `Stream` or ...
5 years ago (2015-12-03 11:44:20 UTC) #2
Lasse Reichstein Nielsen
On second thought, is a class really necessary. This can be implemented by a single ...
5 years ago (2015-12-03 12:08:50 UTC) #3
nweiz
On 2015/12/03 12:08:50, Lasse Reichstein Nielsen wrote: > On second thought, is a class really ...
5 years ago (2015-12-03 21:03:29 UTC) #4
Lasse Reichstein Nielsen
On 2015/12/03 21:03:29, nweiz wrote: > On 2015/12/03 12:08:50, Lasse Reichstein Nielsen wrote: > > ...
5 years ago (2015-12-04 06:44:32 UTC) #5
nweiz
On 2015/12/04 06:44:32, Lasse Reichstein Nielsen wrote: > True. > How about making the class ...
5 years ago (2015-12-10 01:18:42 UTC) #6
Lasse Reichstein Nielsen
On 2015/12/10 01:18:42, nweiz wrote: > I could do that, but it would make some ...
5 years ago (2015-12-10 06:45:28 UTC) #7
nweiz
Code review changes
5 years ago (2015-12-11 00:06:43 UTC) #8
nweiz
https://codereview.chromium.org/1491923005/diff/1/lib/src/lazy_stream.dart File lib/src/lazy_stream.dart (right): https://codereview.chromium.org/1491923005/diff/1/lib/src/lazy_stream.dart#newcode24 lib/src/lazy_stream.dart:24: /// The [callback] may return a `Stream` or a ...
5 years ago (2015-12-11 00:06:58 UTC) #9
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1491923005/diff/1/lib/src/lazy_stream.dart File lib/src/lazy_stream.dart (right): https://codereview.chromium.org/1491923005/diff/1/lib/src/lazy_stream.dart#newcode24 lib/src/lazy_stream.dart:24: /// The [callback] may return a `Stream` or ...
5 years ago (2015-12-11 12:33:21 UTC) #10
nweiz
Code review changes
5 years ago (2015-12-14 21:10:12 UTC) #11
nweiz
https://codereview.chromium.org/1491923005/diff/20001/lib/src/lazy_stream.dart File lib/src/lazy_stream.dart (right): https://codereview.chromium.org/1491923005/diff/20001/lib/src/lazy_stream.dart#newcode32 lib/src/lazy_stream.dart:32: throw new StateError("Stream has already been listened to."); On ...
5 years ago (2015-12-14 21:10:18 UTC) #12
nweiz
5 years ago (2015-12-14 21:10:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
dc829a0a401aed8cfd65daf8a71f590a199cf51c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698