Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 14917022: Added color coding to test results in VM config. (Closed)

Created:
7 years, 7 months ago by gram
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -10 lines) Patch
M pkg/unittest/lib/src/config.dart View 2 chunks +23 lines, -10 lines 1 comment Download
M pkg/unittest/lib/vm_config.dart View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gram
7 years, 7 months ago (2013-05-07 20:05:25 UTC) #1
Siggi Cherem (dart-lang)
lgtm. I used to like that this was a very simple config, though. Would moving ...
7 years, 7 months ago (2013-05-07 20:55:01 UTC) #2
gram
On 2013/05/07 20:55:01, Siggi Cherem (dart-lang) wrote: > lgtm. > > I used to like ...
7 years, 7 months ago (2013-05-07 21:06:00 UTC) #3
gram
Committed patchset #1 manually as r22478 (presubmit successful).
7 years, 7 months ago (2013-05-07 21:34:00 UTC) #4
Andrei Mouravski
7 years, 7 months ago (2013-05-07 22:14:29 UTC) #5
Message was sent while issue was closed.
On 2013/05/07 21:34:00, gram wrote:
> Committed patchset #1 manually as r22478 (presubmit successful).

Have you tried this in other terminal emulators? Does it work on windows, rxvt,
etc?

Powered by Google App Engine
This is Rietveld 408576698