Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1491503002: Make sure we normalize relative()'s return value. (Closed)

Created:
5 years ago by nweiz
Modified:
5 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/path@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make sure we normalize relative()'s return value. I'm not sure why relative() does this, but it's encoded in the tests so we may break people if we change it. R=rnystrom@google.com Committed: https://github.com/dart-lang/path/commit/d63a426a8e71f9c41457547a431bee0fba4f1ac0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/src/context.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
5 years ago (2015-12-01 00:24:01 UTC) #1
Bob Nystrom
LGTM, but it would be good to file a tracking bug to change this back ...
5 years ago (2015-12-01 00:41:58 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as d63a426a8e71f9c41457547a431bee0fba4f1ac0 (presubmit successful).
5 years ago (2015-12-01 04:09:21 UTC) #4
nweiz
5 years ago (2015-12-01 04:09:36 UTC) #5
Message was sent while issue was closed.
On 2015/12/01 04:09:21, nweiz wrote:
> Committed patchset #1 (id:1) manually as
> d63a426a8e71f9c41457547a431bee0fba4f1ac0 (presubmit successful).

https://github.com/dart-lang/path/issues/8

Powered by Google App Engine
This is Rietveld 408576698