Issue 149123003: Handle all debugger stepping with the isolate single step flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149123003: Handle all debugger stepping with the isolate single step flag (Closed)

Created:
6 years, 10 months ago by hausner

Modified:
6 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, iposva, Jacob

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Handle all debugger stepping with the isolate single step flag Eliminate stepping with “internal” breakpoints. We can now handle stepping in recursive functions properly. On the other hand, code does not run at full speed between step commands, since a runtime call to the debugger is necessary at each safe point. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=32150

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -57 lines)			Patch
M	runtime/vm/code_generator.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/debugger.h	View	1	3 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2	11 chunks	+58 lines, -54 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

6 years, 10 months ago (2014-01-29 23:47:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r32150 (presubmit successful).

Expand Messages | Collapse Messages