Clean up the warning for unknown tags.

Clean up the warning for unknown tags.

In addition to looking slicker, this fixes a few issues with the old
implementation:

* Warnings are now printed as part of the corresponding load tests
  rather than just on standard out, meaning that they'll always be
  associated with the appropriate suite.

* Warnings are only printed once per suite, even if that suite is loaded
  on multiple platforms.

* Warnings are printed for tagged groups and suites themselves rather
  than for each test they contain.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/633f004b333c3b37bb33ba33c34811f193d0b072

[kevmoo, 2015-12-02 04:57:01]

lgtm

https://codereview.chromium.org/1490973003/diff/1/lib/src/runner.dart
File lib/src/runner.dart (right):

https://codereview.chromium.org/1490973003/diff/1/lib/src/runner.dart#newcode210
lib/src/runner.dart:210: void _warnForUnknownTags(Suite suite) {
missing an import containing Suite

https://codereview.chromium.org/1490973003/diff/1/test/runner/tag_test.dart
File test/runner/tag_test.dart (right):

https://codereview.chromium.org/1490973003/diff/1/test/runner/tag_test.dart#n...
test/runner/tag_test.dart:8: import
'package:scheduled_test/scheduled_process.dart';
unused import

[kevmoo, 2015-12-02 05:03:57]

also...

https://codereview.chromium.org/1490973003/diff/1/test/runner/tag_test.dart
File test/runner/tag_test.dart (right):

https://codereview.chromium.org/1490973003/diff/1/test/runner/tag_test.dart#n...
test/runner/tag_test.dart:18: d.file("test.dart", """
Make sure this is cleaned up, too. I noticed it sitting around after running
tests...

[nweiz, 2015-12-02 22:21:10]

Code review changes

[nweiz, 2015-12-02 22:21:17]

https://codereview.chromium.org/1490973003/diff/1/lib/src/runner.dart
File lib/src/runner.dart (right):

https://codereview.chromium.org/1490973003/diff/1/lib/src/runner.dart#newcode210
lib/src/runner.dart:210: void _warnForUnknownTags(Suite suite) {
On 2015/12/02 04:57:01, kevmoo wrote:
> missing an import containing Suite

Done.

https://codereview.chromium.org/1490973003/diff/1/test/runner/tag_test.dart
File test/runner/tag_test.dart (right):

https://codereview.chromium.org/1490973003/diff/1/test/runner/tag_test.dart#n...
test/runner/tag_test.dart:8: import
'package:scheduled_test/scheduled_process.dart';
On 2015/12/02 04:57:01, kevmoo wrote:
> unused import

Done.

https://codereview.chromium.org/1490973003/diff/1/test/runner/tag_test.dart#n...
test/runner/tag_test.dart:18: d.file("test.dart", """
On 2015/12/02 05:03:56, kevmoo wrote:
> Make sure this is cleaned up, too. I noticed it sitting around after running
> tests...

Everything in the sandbox should be cleaned up by useSandbox(). If you're seeing
this consistently, can you debug into it a bit and see what's up?

[nweiz, 2015-12-02 22:21:28]

Description was changed from

==========
Clean up the warning for unknown tags.

In addition to looking slicker, this fixes a few issues with the old
implementation:

* Warnings are now printed as part of the corresponding load tests
  rather than just on standard out, meaning that they'll always be
  associated with the appropriate suite.

* Warnings are only printed once per suite, even if that suite is loaded
  on multiple platforms.

* Warnings are printed for tagged groups and suites themselves rather
  than for each test they contain.

R=kevmoo@google.com
==========

to

==========
Clean up the warning for unknown tags.

In addition to looking slicker, this fixes a few issues with the old
implementation:

* Warnings are now printed as part of the corresponding load tests
  rather than just on standard out, meaning that they'll always be
  associated with the appropriate suite.

* Warnings are only printed once per suite, even if that suite is loaded
  on multiple platforms.

* Warnings are printed for tagged groups and suites themselves rather
  than for each test they contain.

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/test/commit/633f004b333c3b37bb33ba33c34811f193d0...
==========

[nweiz, 2015-12-02 22:21:29]

Committed patchset #2 (id:20001) manually as
633f004b333c3b37bb33ba33c34811f193d0b072 (presubmit successful).