Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 14908005: "Reverting 22561" (Closed)

Created:
7 years, 7 months ago by Jennifer Messerly
Modified:
7 years, 7 months ago
Reviewers:
CC:
reviews_dartlang.org
Visibility:
Public.

Description

"Reverting 22561" need to investigate test failures Committed: https://code.google.com/p/dart/source/detail?r=22562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+742 lines, -8839 lines) Patch
D pkg/mdv_observe/lib/mdv_observe.dart View 1 chunk +0 lines, -104 lines 0 comments Download
D pkg/mdv_observe/lib/src/observable_box.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/mdv_observe/lib/src/observable_list.dart View 1 chunk +0 lines, -288 lines 0 comments Download
D pkg/mdv_observe/lib/src/observable_map.dart View 1 chunk +0 lines, -149 lines 0 comments Download
D pkg/mdv_observe/pubspec.yaml View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/mdv_observe/test/list_change_test.dart View 1 chunk +0 lines, -290 lines 0 comments Download
D pkg/mdv_observe/test/observable_list_test.dart View 1 chunk +0 lines, -245 lines 0 comments Download
D pkg/mdv_observe/test/observable_map_test.dart View 1 chunk +0 lines, -241 lines 0 comments Download
D pkg/mdv_observe/test/observe_test.dart View 1 chunk +0 lines, -130 lines 0 comments Download
D pkg/mdv_observe/test/utils.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 18 chunks +177 lines, -1546 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 16 chunks +169 lines, -1524 lines 0 comments Download
D sdk/lib/mdv_observe_impl/mdv_observe_impl.dart View 1 chunk +0 lines, -226 lines 0 comments Download
D tests/html/binding_syntax_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D tests/html/element_bindings_test.dart View 1 chunk +0 lines, -344 lines 0 comments Download
D tests/html/mdv_observe_utils.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/html/node_bindings_test.dart View 1 chunk +0 lines, -156 lines 0 comments Download
A tests/html/node_model_test.dart View 1 chunk +192 lines, -0 lines 0 comments Download
D tests/html/path_observer_test.dart View 1 chunk +0 lines, -255 lines 0 comments Download
D tests/html/template_element_test.dart View 1 chunk +0 lines, -1503 lines 0 comments Download
M tools/create_sdk.py View 3 chunks +4 lines, -5 lines 0 comments Download
M tools/dom/dom.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -1 line 0 comments Download
A tools/dom/src/ModelTreeObserver.dart View 1 chunk +100 lines, -0 lines 0 comments Download
D tools/dom/src/PathObserver.dart View 1 chunk +0 lines, -286 lines 0 comments Download
D tools/dom/src/TemplateBindings.dart View 1 chunk +0 lines, -776 lines 0 comments Download
M tools/dom/src/dart2js_Conversions.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 4 chunks +15 lines, -260 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLInputElement.darttemplate View 1 chunk +0 lines, -60 lines 0 comments Download
D tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 1 chunk +0 lines, -119 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 2 chunks +79 lines, -32 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Text.darttemplate View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jennifer Messerly
7 years, 7 months ago (2013-05-09 20:43:42 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r22562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698