Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 14907009: dart:io | Tiny change to Link.exists(). (Closed)

Created:
7 years, 7 months ago by Bill Hesse
Modified:
7 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Tiny change to Link.exists(). BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22368

Patch Set 1 #

Patch Set 2 : Fix static type errors in new test for dartc analyzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M sdk/lib/io/file_system_entity.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/link.dart View 1 chunk +1 line, -4 lines 0 comments Download
M tests/standalone/io/file_invalid_arguments_test.dart View 1 2 chunks +21 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 7 months ago (2013-05-03 12:11:34 UTC) #1
Søren Gjesse
lgtm
7 years, 7 months ago (2013-05-03 12:38:06 UTC) #2
Bill Hesse
7 years, 7 months ago (2013-05-03 12:39:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22368 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698