Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14907008: Remove support for interface in dart2js. (Closed)

Created:
7 years, 7 months ago by Johnni Winther
Modified:
7 years, 7 months ago
Reviewers:
ahe, Anton Muhin, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove support for interface in dart2js. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=22403

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix constructor name bug. #

Total comments: 8

Patch Set 4 : Updated cf. comments. #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -440 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 2 3 4 1 chunk +0 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 2 chunks +0 lines, -17 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 2 3 4 4 chunks +2 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 4 8 chunks +1 line, -146 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/scope.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/keyword.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 5 chunks +1 line, -55 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 3 chunks +1 line, -43 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tools/mini_parser.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/prettyprint.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/unparser.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 3 chunks +4 lines, -5 lines 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 2 10 chunks +15 lines, -15 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 6 chunks +15 lines, -50 lines 0 comments Download
M tests/compiler/dart2js/deprecated_features_test.dart View 1 2 3 3 chunks +4 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_window1_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_foreign/native_window2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/downcast_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check1_frog_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_class_is_check3_frog_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_native/native_field_rename_2_frog_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_library_same_name_used_lib1.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_window1_frog_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_native/native_window2_frog_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/constructor_name_test.dart View 1 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Johnni Winther
7 years, 7 months ago (2013-05-03 13:12:51 UTC) #1
ahe
LGTM! https://codereview.chromium.org/14907008/diff/15002/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (left): https://codereview.chromium.org/14907008/diff/15002/sdk/lib/_internal/compiler/implementation/resolution/members.dart#oldcode360 sdk/lib/_internal/compiler/implementation/resolution/members.dart:360: void resolveConstructorImplementation(FunctionElement constructor, YAY! https://codereview.chromium.org/14907008/diff/15002/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart File sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart (right): ...
7 years, 7 months ago (2013-05-03 13:57:34 UTC) #2
Johnni Winther
https://codereview.chromium.org/14907008/diff/15002/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart File sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart (right): https://codereview.chromium.org/14907008/diff/15002/sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart#newcode91 sdk/lib/_internal/compiler/implementation/scanner/class_element_parser.dart:91: SourceString getMethodNameHack(Node methodName) { On 2013/05/03 13:57:34, ahe wrote: ...
7 years, 7 months ago (2013-05-06 06:16:42 UTC) #3
Johnni Winther
Committed patchset #5 manually as r22403 (presubmit successful).
7 years, 7 months ago (2013-05-06 06:22:53 UTC) #4
ahe
7 years, 7 months ago (2013-05-07 06:31:19 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/14907008/diff/15002/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/14907008/diff/15002/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/warnings.dart:52: 'Error: Unnamed
constructor name must be #{name}.');
On 2013/05/06 06:16:42, Johnni Winther wrote:
> On 2013/05/03 13:57:34, ahe wrote:
> > How can this happen?
> 
> For factory constructors.

It is a bit wierd to talk about "unnamed constructors" having the wrong name.
Also, if this applies only to factory methods, the error message should mention
the word "factory".

Powered by Google App Engine
This is Rietveld 408576698