Issue 14907002: dart:io | Implement asynchronous versions of FileSystemEntity methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14907002: dart:io | Implement asynchronous versions of FileSystemEntity methods. (Closed)

Created:
7 years, 7 months ago by Bill Hesse

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

dart:io | Implement truly asynchronous version of FileSystemEntity.type(). BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22364

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -43 lines)			Patch
M	runtime/bin/file.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/bin/file.cc	View	1	2 chunks	+39 lines, -0 lines	0 comments	Download
M	runtime/bin/file_system_entity_patch.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/common.dart	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	sdk/lib/io/directory_impl.dart	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1	3 chunks	+4 lines, -25 lines	0 comments	Download
M	sdk/lib/io/file_system_entity.dart	View	1	4 chunks	+35 lines, -9 lines	0 comments	Download
M	tests/standalone/io/file_invalid_arguments_test.dart	View	1	2 chunks	+34 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Bill Hesse

Now this is ready for review, with the remaining function in FileSystemEntity implemented as well. ...

7 years, 7 months ago (2013-05-03 11:37:44 UTC) #3

Bill Hesse

7 years, 7 months ago (2013-05-03 12:02:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r22364 (presubmit successful).