Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 149063005: Increase the timeout for a failing pub test. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Increase the timeout for a failing pub test. TBR R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=32096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M sdk/lib/_internal/pub/test/serve/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/transformer/dart2js/converts_isolate_entrypoint_in_web_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 10 months ago (2014-01-29 00:03:28 UTC) #1
nweiz
Committed patchset #1 manually as r32096 (presubmit successful).
6 years, 10 months ago (2014-01-29 00:03:40 UTC) #2
Bob Nystrom
6 years, 10 months ago (2014-01-29 17:04:28 UTC) #3
Message was sent while issue was closed.
LGTM.

Can you email the dart2js folks and ask if this behavior is expected too? I want
to make sure they know about this as well.

Powered by Google App Engine
This is Rietveld 408576698