Issue 14905003: Update mime_multipart_parser to be a StreamTransformer, public available.

Issue 14905003: Update mime_multipart_parser to be a StreamTransformer, public available. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update mime_multipart_parser to be a StreamTransformer, public available. On top of this, we can put in more user-friendly version, including header objects. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22358

Patch Set 1 #

Total comments: 10

Patch Set 2 : review changes #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+264 lines, -216 lines)			Patch
	M	sdk/lib/io/mime_multipart_parser.dart	View	1	9 chunks	+230 lines, -156 lines	0 comments	Download
	M	tests/standalone/io/mime_multipart_parser_test.dart	View	1	4 chunks	+34 lines, -60 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM https://codereview.chromium.org/14905003/diff/1/sdk/lib/io/mime_multipart_parser.dart File sdk/lib/io/mime_multipart_parser.dart (right): https://codereview.chromium.org/14905003/diff/1/sdk/lib/io/mime_multipart_parser.dart#newcode10 sdk/lib/io/mime_multipart_parser.dart:10: * [MimeMultipartTransformer]. The data is streamed in as ...

7 years, 7 months ago (2013-05-03 08:30:48 UTC) #2

Anders Johnsen

Committed patchset #2 manually as r22358 (presubmit successful).

7 years, 7 months ago (2013-05-03 09:31:10 UTC) #3

Anders Johnsen

7 years, 7 months ago (2013-05-03 10:22:54 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14905003/diff/1/sdk/lib/io/mime_multipart_par...
File sdk/lib/io/mime_multipart_parser.dart (right):

https://codereview.chromium.org/14905003/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:10: * [MimeMultipartTransformer]. The data
is streamed in as it become available.
On 2013/05/03 08:30:48, Søren Gjesse wrote:
> Maybe add some code to show how to use it to collect a form post into a
> Map<String, String>.

That's actually quite complicated (header parsing, folding, etc.). I think we
should add that, as part of the next step for this; an actual transformer doing
it.

https://codereview.chromium.org/14905003/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:130: onCancel: () {
On 2013/05/03 08:30:48, Søren Gjesse wrote:
> Do you need to specify this empty onCancel closure?

Done.

https://codereview.chromium.org/14905003/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:314: if (_toLowerCase(byte) ==
_toLowerCase(_boundary[_boundaryIndex])) {
On 2013/05/03 08:30:48, Søren Gjesse wrote:
> I know I worte this code, but looking at RFC2046 I don't see that the boundary
> matching should be case insensitive.

Done.

https://codereview.chromium.org/14905003/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:390: print("BAD");
On 2013/05/03 08:30:48, Søren Gjesse wrote:
> Debug print.

Done.

https://codereview.chromium.org/14905003/diff/1/sdk/lib/io/mime_multipart_par...
sdk/lib/io/mime_multipart_parser.dart:397: print("BAD");
On 2013/05/03 08:30:48, Søren Gjesse wrote:
> Debug print.

Done.

Expand Messages | Collapse Messages