Issue 14897006: Improve parsing of query string

Issue 14897006: Improve parsing of query string (Closed)

Created:
7 years, 7 months ago by Søren Gjesse

Modified:
7 years, 7 months ago

Reviewers:
Anders Johnsen, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve parsing of query string R=ager@google.com BUG=https://code.google.com/p/dart/issues/detail?id=10168 TEST=tests/standalone/io/url_encoding_test.dart Committed: https://code.google.com/p/dart/source/detail?r=22728

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -23 lines)			Patch
M	sdk/lib/io/http_parser.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/io/http_utils.dart	View	1	1 chunk	+42 lines, -12 lines	0 comments	Download
M	tests/standalone/io/url_encoding_test.dart	View	1	1 chunk	+60 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM! https://codereview.chromium.org/14897006/diff/1/sdk/lib/io/http_utils.dart File sdk/lib/io/http_utils.dart (right): https://codereview.chromium.org/14897006/diff/1/sdk/lib/io/http_utils.dart#newcode74 sdk/lib/io/http_utils.dart:74: // the length of the quesy string. query ...

7 years, 7 months ago (2013-05-15 09:17:35 UTC) #2

Søren Gjesse

Thanks for reviewing this (my spelling of ajohnsen@google.com was pretty bad). https://codereview.chromium.org/14897006/diff/1/sdk/lib/io/http_utils.dart File sdk/lib/io/http_utils.dart (right): ...

7 years, 7 months ago (2013-05-15 09:22:17 UTC) #3

Søren Gjesse

7 years, 7 months ago (2013-05-15 09:29:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22728 (presubmit successful).

Expand Messages | Collapse Messages