Issue 14890026: Handle switch statement in simple types inferrer.

Issue 14890026: Handle switch statement in simple types inferrer. (Closed)

Created:
7 years, 7 months ago by ngeoffray

Modified:
7 years, 7 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Handle switch statement in simple types inferrer. BUG=10581 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=22850

Patch Set 4 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -0 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 2 3	1 chunk	+23 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1 2 3	1 chunk	+41 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_test.dart	View	1 2 3	3 chunks	+37 lines, -0 lines	0 comments	Download
A	tests/language/issue10581_test.dart	View		1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/14890026/diff/2004/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/14890026/diff/2004/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode2371 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2371: } Add a TODO to handle switch statements ...

7 years, 7 months ago (2013-05-15 13:14:14 UTC) #2

ngeoffray

Thanks Johnni. PTAL. https://codereview.chromium.org/14890026/diff/7001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/14890026/diff/7001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode2389 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2389: // fixed point. I'll wait for ...

7 years, 7 months ago (2013-05-15 15:06:57 UTC) #3

Johnni Winther

lgtm https://codereview.chromium.org/14890026/diff/7001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/14890026/diff/7001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode2387 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2387: // If the swiwtch statement has a continue, ...

7 years, 7 months ago (2013-05-17 08:39:36 UTC) #4

ngeoffray

Thanks Johnni. https://codereview.chromium.org/14890026/diff/7001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/14890026/diff/7001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode2387 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:2387: // If the swiwtch statement has a ...

7 years, 7 months ago (2013-05-17 11:48:54 UTC) #5

ngeoffray

7 years, 7 months ago (2013-05-17 14:46:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r22850 (presubmit successful).

Expand Messages | Collapse Messages