Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 148893004: Docgen snapshot needs to use dart-sdk as its SDK root in a downloaded SDK (Closed)

Created:
6 years, 10 months ago by Alan Knight
Modified:
6 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Docgen snapshot needs to use dart-sdk as its SDK root in a downloaded SDK BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32453

Patch Set 1 #

Patch Set 2 : Also find the root directory more robustly, and tolerate not having MDN docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M pkg/docgen/lib/docgen.dart View 1 3 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
6 years, 10 months ago (2014-02-07 21:26:23 UTC) #1
Emily Fortuna
lgtm!
6 years, 10 months ago (2014-02-07 21:34:50 UTC) #2
Alan Knight
6 years, 10 months ago (2014-02-07 21:41:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698