Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Issue 148893002: Give default value for builder_tag in test options (Closed)

Created:
6 years, 10 months ago by ricow1
Modified:
6 years, 10 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Give default value for builder_tag in test options Remove now passing test pkgbuild/samples/third_party/angular_todo suppression Committed: https://code.google.com/p/dart/source/detail?r=32068

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M pkg/pkgbuild.status View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 10 months ago (2014-01-28 14:32:29 UTC) #1
ricow1
TBR
6 years, 10 months ago (2014-01-28 14:47:08 UTC) #2
ricow1
Committed patchset #3 manually as r32068 (presubmit successful).
6 years, 10 months ago (2014-01-28 14:47:32 UTC) #3
Anders Johnsen
6 years, 10 months ago (2014-01-29 11:55:43 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698