Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 14886015: Use runAsync for Futures. (Closed)

Created:
7 years, 7 months ago by floitsch
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M pkg/scheduled_test/lib/src/utils.dart View 1 1 chunk +5 lines, -1 line 0 comments Download
M pkg/unittest/test/unittest_test.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
I tried to make the unittest test have a Timer.run section but that didn't work. ...
7 years, 7 months ago (2013-05-10 23:43:13 UTC) #1
nweiz
One request, otherwise LGTM. https://codereview.chromium.org/14886015/diff/1/pkg/scheduled_test/lib/src/utils.dart File pkg/scheduled_test/lib/src/utils.dart (right): https://codereview.chromium.org/14886015/diff/1/pkg/scheduled_test/lib/src/utils.dart#newcode55 pkg/scheduled_test/lib/src/utils.dart:55: return new Future.delayed(Duration.ZERO, () => ...
7 years, 7 months ago (2013-05-10 23:49:43 UTC) #2
Lasse Reichstein Nielsen
lgtm
7 years, 7 months ago (2013-05-13 08:05:00 UTC) #3
floitsch
https://codereview.chromium.org/14886015/diff/1/pkg/scheduled_test/lib/src/utils.dart File pkg/scheduled_test/lib/src/utils.dart (right): https://codereview.chromium.org/14886015/diff/1/pkg/scheduled_test/lib/src/utils.dart#newcode55 pkg/scheduled_test/lib/src/utils.dart:55: return new Future.delayed(Duration.ZERO, () => pumpEventQueue(times - 1)); On ...
7 years, 7 months ago (2013-05-13 10:52:48 UTC) #4
floitsch
7 years, 7 months ago (2013-05-13 10:53:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698