use .append instead of .nodes.add

use .append instead of .nodes.add

R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22652

[Jennifer Messerly, 2013-05-13 20:01:47]

as suggested in another code review. I replaced everything except node_test and
element_test; those two seemed to be intentionally testing nodes.add

[blois, 2013-05-13 20:06:03]

lgtm, for reference, this is primarily due to better codegen for append vs
nodes.add. So not really needed for tests, but it is a good best practice.

[Emily Fortuna, 2013-05-13 20:07:43]

Pete- do we have documentation of this? If not, can we add it? :-D

[Jennifer Messerly, 2013-05-13 20:08:50]

On 2013/05/13 20:07:43, Emily Fortuna wrote:
> Pete- do we have documentation of this? If not, can we add it? :-D

it doesn't appear to be documented:
http://api.dartlang.org/docs/bleeding_edge/dart_html/Node.html#append

how do I add it?

[Emily Fortuna, 2013-05-13 20:14:20]

er, good point -- Talk to Andrei. 
Hack idea #1: Follow the JSON format and manually add an entry for Node with the
append documentation.
Hack idea #2: modify tools/dom/templates/html/imp/impl_node.darttemplate and add
the append method there, have it just call the native version, and add your
documentation.

Both of those ideas are pretty bad. I hope Andrei has better ones.

[blois, 2013-05-13 20:18:07]

Hack #3- ask Andrei to add it :)

You should be able to manually edit html_dartium.dart, then run "tools/dom.py
docs"

[Jennifer Messerly, 2013-05-13 20:58:05]

Committed patchset #2 manually as r22652 (presubmit successful).

[Jennifer Messerly, 2013-05-13 21:08:01]

fyi, since we might want to iterate on the docs I made another CL here:

https://codereview.chromium.org/15102013/