Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 148783002: Fix debugger stepping (Closed)

Created:
6 years, 10 months ago by hausner
Modified:
6 years, 10 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix debugger stepping Recently I eliminated PC descriptors for some calls. This change makes sure we handle single stepping on those call sites properly.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M runtime/vm/debugger.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 10 months ago (2014-01-28 02:59:46 UTC) #1
regis
LGTM
6 years, 10 months ago (2014-01-28 03:07:06 UTC) #2
hausner
6 years, 10 months ago (2014-01-28 16:36:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r32071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698