Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1487753003: Fix a couple bugs in the JSON schema. (Closed)

Created:
5 years ago by nweiz
Modified:
5 years ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org, messick
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a couple bugs in the JSON schema. This adds missing Test.groupIDs and PrintEvent.testID fields, and adds a description to clarify the purpose of FutureEvent. It also now verifies that the protocol version is compatible. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/fedd3925735b67f85c188d85e1cc0cf2e1084f48

Patch Set 1 #

Patch Set 2 : Have the schema verify the protocol version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M json_reporter.schema.json View 1 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nweiz
5 years ago (2015-11-30 22:16:37 UTC) #2
kevmoo
LGTM...but... Is there a way to validate this? Are you using a tool?
5 years ago (2015-11-30 22:25:55 UTC) #4
nweiz
On 2015/11/30 22:25:55, kevmoo wrote: > Is there a way to validate this? Are you ...
5 years ago (2015-11-30 22:35:45 UTC) #5
nweiz
5 years ago (2015-11-30 22:36:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fedd3925735b67f85c188d85e1cc0cf2e1084f48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698